-
Notifications
You must be signed in to change notification settings - Fork 99
Hack/grafana mcp #6696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wdvr
wants to merge
68
commits into
main
Choose a base branch
from
hack/grafana_mcp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Hack/grafana mcp #6696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strip extra newlines
…sues (#6661) Most of this is moving code around and changing APIs for things Only major change in e2e behavior is that the fall back for invalid disable test title is to assume its a job name and will attempt to disable the weirdly named job. Previously it would say the title is malformed for a test Changes: * Fall back thing mentioned above * API/moving code around ex * Move module label logic moved to other file * Move parsing of issue body into other file * Testing * I converted a lot of tests to be more integration style tests so we change change the api more often and tests will still be valid --------- Co-authored-by: Zain Rizvi <[email protected]>
Requires changes in #6661, please review + merge that one first Allow flakybot to make aggregate issues, update them, and close them. Also allow the verification bot that comments on each issue to do aggregate issues. Format should match the one in #6045 We should really make the verification script just the same as the script that updates the json... No platform module labels are going to be added There's some weirdness with closing issues / removing tests that are no longer flaky because I think it's hard (read: possible, probably annoying) to determine which test is responsible for an issue getting updated and which are old enough to be removed Threshold is 10
This should allow fbgemm_gpu_genai to be visible on nightly index
) We require Wheel file manipulation stripping suffixes. Also from time to time we inject requirements into wheel METADATA to work around limitations with poetry. Using python and auditwheel make it simplier to modify and maintain this script. For example no RECORD file regeneration with the new SHA is necessary, auditwheel does it for you. Preparing to do Metadata injection since it was removed by this PR: pytorch/pytorch#152333 Related to Poetry issue: pytorch/pytorch#152121 Testing: ``` DRY_RUN=disabled ./promote_pypi_to_staging.sh =-=-=-= Promoting torch's v2.7.1 to pypi staging' =-=-=-= + PACKAGE_VERSION=2.7.1 + PACKAGE_NAME=torch + DRY_RUN=disabled + bash /home/ec2-user/github/test-infra-r27/release/pypi/upload_pypi_to_staging.sh Requesting cu126 https://download.pytorch.org/whl/test/cu126/torch/index.html For torch-2.7.1%2Bcu126 /tmp/tmp.sGF5bXVuGs ~/github/test-infra-r27/release/pypi Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 784M 100 784M 0 0 34.7M 0 0:00:22 0:00:22 --:--:-- 37.8M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl + ls -las total 801912 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:24 . 0 drwxrwxrwt. 17 root root 380 May 29 16:24 .. 801912 -rw-r--r--. 1 ec2-user ec2-user 821154516 May 29 16:24 torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 784M 100 784M 0 0 32.4M 0 0:00:24 0:00:24 --:--:-- 34.6M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl + ls -las total 801932 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:26 . 0 drwxrwxrwt. 17 root root 380 May 29 16:26 .. 801932 -rw-r--r--. 1 ec2-user ec2-user 821174704 May 29 16:26 torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 783M 100 783M 0 0 34.0M 0 0:00:23 0:00:23 --:--:-- 37.1M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl + ls -las total 801784 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:28 . 0 drwxrwxrwt. 17 root root 380 May 29 16:28 .. 801784 -rw-r--r--. 1 ec2-user ec2-user 821025792 May 29 16:28 torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 783M 100 783M 0 0 34.5M 0 0:00:22 0:00:22 --:--:-- 39.1M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl + ls -las total 801792 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:31 . 0 drwxrwxrwt. 17 root root 380 May 29 16:31 .. 801792 -rw-r--r--. 1 ec2-user ec2-user 821033192 May 29 16:31 torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 783M 100 783M 0 0 29.9M 0 0:00:26 0:00:26 --:--:-- 31.4M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl + ls -las total 801856 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:33 . 0 drwxrwxrwt. 17 root root 380 May 29 16:33 .. 801856 -rw-r--r--. 1 ec2-user ec2-user 821098066 May 29 16:33 torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 784M 100 784M 0 0 33.0M 0 0:00:23 0:00:23 --:--:-- 32.0M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl + ls -las total 801904 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:35 . 0 drwxrwxrwt. 17 root root 380 May 29 16:35 .. 801904 -rw-r--r--. 1 ec2-user ec2-user 821146689 May 29 16:35 torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl ```
Currently we move some of our lambda function in test-infra/aws/lambda, and maintain the infra resources in https://github.com/pytorch-labs/pytorch-gha-infra/. It's not very straightforward process, so add a guidance: This readme is based on my experience setup lambda for [oss_ci_job_queue_time]( https://github.com/pytorch/test-infra/tree/main/aws/lambda/oss_ci_job_queue_time), --------- Signed-off-by: Yang Wang <[email protected]>
…me (#6684) Brings down the minimum_running_time_in_minutes that was earlier increased in #6477 In order to do so, it required a few changes: 1. Remove the check to always treat minimumRunningTimeInMinutes as 5 less than it actually was. This logic had likely been added to account for the 5 minutes it can take for a runner to be refreshed. 2. Instead, add a buffer of 5 mins to the scale down cron job for when 3. Handle the case when both EC2 tags, ebsVolumeReplacementRequestTimestamp and ephemeralRunnerFinished, are set during scale down (which happens in a narrow window during refresh)
always UTC, not local, to avoid dates being reported as the wrong date
Typo go bye bye
These were configurations that had been added back in the days when our autoscaler had to support multiple base linux OS's. Given that we only use Amazon Linux 2023 now we don't need them any more A breakdown of the removed entries: * Some of the removed configs were to support Amazon Linux 2, such as: * The amz vs amz2023 checks * The configurable package manager...which was inconsistently used) * I suspect the nvidia-docker tools being in a conditional was from when we used Ubuntu (based on [this old commit](fd29941) that added the conditional). Apparently Ubuntu didn't require the same set of dependencies to be installed. None of that is needed now, so removing those lines to clean up this file
Bumps [setuptools](https://github.com/pypa/setuptools) from 70.0.0 to 78.1.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/setuptools/blob/main/NEWS.rst">setuptools's changelog</a>.</em></p> <blockquote> <h1>v78.1.1</h1> <h2>Bugfixes</h2> <ul> <li>More fully sanitized the filename in PackageIndex._download. (<a href="https://redirect.github.com/pypa/setuptools/issues/4946">#4946</a>)</li> </ul> <h1>v78.1.0</h1> <h2>Features</h2> <ul> <li>Restore access to _get_vc_env with a warning. (<a href="https://redirect.github.com/pypa/setuptools/issues/4874">#4874</a>)</li> </ul> <h1>v78.0.2</h1> <h2>Bugfixes</h2> <ul> <li>Postponed removals of deprecated dash-separated and uppercase fields in <code>setup.cfg</code>. All packages with deprecated configurations are advised to move before 2026. (<a href="https://redirect.github.com/pypa/setuptools/issues/4911">#4911</a>)</li> </ul> <h1>v78.0.1</h1> <h2>Misc</h2> <ul> <li><a href="https://redirect.github.com/pypa/setuptools/issues/4909">#4909</a></li> </ul> <h1>v78.0.0</h1> <h2>Bugfixes</h2> <ul> <li>Reverted distutils changes that broke the monkey patching of command classes. (<a href="https://redirect.github.com/pypa/setuptools/issues/4902">#4902</a>)</li> </ul> <h2>Deprecations and Removals</h2> <ul> <li>Setuptools no longer accepts options containing uppercase or dash characters in <code>setup.cfg</code>.</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/setuptools/commit/8e4868a036b7fae3208d16cb4e5fe6d63c3752df"><code>8e4868a</code></a> Bump version: 78.1.0 → 78.1.1</li> <li><a href="https://github.com/pypa/setuptools/commit/100e9a61ad24d5a147ada57357425a8d40626d09"><code>100e9a6</code></a> Merge pull request <a href="https://redirect.github.com/pypa/setuptools/issues/4951">#4951</a></li> <li><a href="https://github.com/pypa/setuptools/commit/8faf1d7e0ca309983252e4f21837b73ee12e960f"><code>8faf1d7</code></a> Add news fragment.</li> <li><a href="https://github.com/pypa/setuptools/commit/2ca4a9fe4758fcd39d771d3d3a5b4840aacebdf7"><code>2ca4a9f</code></a> Rely on re.sub to perform the decision in one expression.</li> <li><a href="https://github.com/pypa/setuptools/commit/e409e8002932f2b86aae7b1abc8f8c2ebf96df2c"><code>e409e80</code></a> Extract _sanitize method for sanitizing the filename.</li> <li><a href="https://github.com/pypa/setuptools/commit/250a6d17978f9f6ac3ac887091f2d32886fbbb0b"><code>250a6d1</code></a> Add a check to ensure the name resolves relative to the tmpdir.</li> <li><a href="https://github.com/pypa/setuptools/commit/d8390feaa99091d1ba9626bec0e4ba7072fc507a"><code>d8390fe</code></a> Extract _resolve_download_filename with test.</li> <li><a href="https://github.com/pypa/setuptools/commit/4e1e89392de5cb405e7844cdc8b20fc2755dbaba"><code>4e1e893</code></a> Merge <a href="https://github.com/jaraco/skeleton">https://github.com/jaraco/skeleton</a></li> <li><a href="https://github.com/pypa/setuptools/commit/3a3144f0d2887fa37c06550f42a101e9eebd953a"><code>3a3144f</code></a> Fix typo: <code>pyproject.license</code> -> <code>project.license</code> (<a href="https://redirect.github.com/pypa/setuptools/issues/4931">#4931</a>)</li> <li><a href="https://github.com/pypa/setuptools/commit/d751068fd2627d6d8f1729e39cbcd8119049998f"><code>d751068</code></a> Fix typo: pyproject.license -> project.license</li> <li>Additional commits viewable in <a href="https://github.com/pypa/setuptools/compare/v70.0.0...v78.1.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/pytorch/test-infra/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.