Skip to content

[ez][HUD] host -> url for clickhouse client #6705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

[ez][HUD] host -> url for clickhouse client #6705

merged 1 commit into from
Jun 4, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jun 3, 2025 •
edited
Loading

Kept getting

[2025-06-03T23:06:31.978Z][WARN][@clickhouse/client][Config] "host" is deprecated. Use "url" instead.

when developing locally

typescript says

(property) BaseClickHouseClientConfigOptions.host?: string | undefined
@deprecated
since version 1.0.0. Use [url](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html) instead. A ClickHouse instance URL.

@default

Local seems normal? Preview looks ok

@vercel Vercel
Copy link

vercel bot commented Jun 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jun 3, 2025 11:11pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2025
@clee2000 clee2000 changed the title [HUD] host -> url for clickhouse client [ez][HUD] host -> url for clickhouse client Jun 3, 2025
@clee2000 clee2000 marked this pull request as ready for review June 4, 2025 15:32
@clee2000 clee2000 requested a review from a team June 4, 2025 15:32
malfet
malfet approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

@malfet malfet merged commit 946dfd3 into main Jun 4, 2025
6 checks passed
@malfet malfet deleted the csl/clickhouse_url_host branch June 4, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clee2000 @seemethere @malfet @facebook-github-bot