[BE][Refresh-runner 1.5/4][BE] reorg the tryReuse method into small pieces #6709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jeanschmidt
reviewed
Jun 5, 2025
terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/runners.ts
Outdated
Show resolved
Hide resolved
jeanschmidt
reviewed
Jun 5, 2025
terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/runners.ts
Show resolved
Hide resolved
jeanschmidt
reviewed
Jun 5, 2025
terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/runners.ts
Outdated
Show resolved
Hide resolved
jeanschmidt
approved these changes
Jun 5, 2025
|
approved with small improvements. please make sure to get green signals in all your checks before merging. Lintrunner is failing :) |
zxiiro
reviewed
Jun 5, 2025
terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/runners.ts
Outdated
Show resolved
Hide resolved
zxiiro
approved these changes
Jun 5, 2025
wdvr
pushed a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the function more readable
some of those method would be reusable for my new lambda
a follow-up from #6702