Skip to content

[better catch] Add banner for github action issue #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2025
Merged

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Jun 5, 2025

When there is unreovled github service incident, the banner pops up in hud. The banner disapear when the incident is resovled

image image

Signed-off-by: Yang Wang <[email protected]>
Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jun 5, 2025 8:31pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@yangw-dev yangw-dev marked this pull request as ready for review June 5, 2025 19:39
Copy link
Contributor

@izaitsevfb izaitsevfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nit: this could be client-only change, as https://www.githubstatus.com/api/v2/incidents/unresolved.json doesn't enforce CORS

Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. This would also be really helpful to include in the Dr. CI response (as a separate PR though)

@yangw-dev
Copy link
Contributor Author

lgtm

nit: this could be client-only change, as https://www.githubstatus.com/api/v2/incidents/unresolved.json doesn't enforce CORS

Not really familiar with the Dr.Ci code, would be appreciated if you can send me a url

Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
yangw-dev added 3 commits June 5, 2025 13:19
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev merged commit bc48cee into main Jun 5, 2025
5 checks passed
@yangw-dev yangw-dev deleted the addIncidentNoti branch June 5, 2025 20:40
@yangw-dev yangw-dev changed the title [proposal] Add banner for github action issue [better catch] Add banner for github action issue Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants