tools: Update clear_offline_runners to clear ec2 #6721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently had an outage that required that we spin down all instances that were not actively connected to GitHub. Signed-off-by: Eli Uriegas <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zxiiro
approved these changes
Jun 6, 2025
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
zxiiro
reviewed
Jun 6, 2025
| Github, | ||
| PaginatedList, | ||
| SelfHostedActionsRunner, | ||
| ) | ||
| from tqdm import tqdm # type: ignore[import-untyped] | ||
|
|
||
|
|
There was a problem hiding this comment.
Github won't let me propose changes to lines that didn't change :(
Adding a new argument for runner_name below would be useful as LF account has a different action runner name.
parser.add_argument(
"--runner-name",
help="AWS Runner Name to filter for EC2 instances.",
type=str,
default="gh-ci-action-runner",
)
Co-authored-by: Thanh Ha <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
|
The linter issues are not my issues, will follow up with a PR to fix most of them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had an outage that required that we spin down all instances that were not actively connected to GitHub.
Requirements to run:
To run you can use:
This was used to remediate issues from pytorch/pytorch#155265