[autorevert] Fix bug on job retrival for autorevert lambda - #6979
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the autorevert lambda's job retrieval logic and improves its ergonomics. The main bug was that when checking for commits with the same job before/after, the system concatenated all commits+jobs instead of returning only the next one. This resulted in inaccurate pattern detection.
- Fixed job retrieval logic in
_find_last_commit_with_jobmethod - Added support for ignoring common error types (GHA errors, timeouts, sccache errors)
- Enhanced lambda invocation ergonomics with better command-line options
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| autorevert.py | Added ignore_common_errors parameter and improved output formatting |
| autorevert_checker.py | Fixed job retrieval bug and added classification rule filtering |
| main.py | Added lambda ergonomics and new command-line options |
| Makefile | Updated run command to use new parameters |
zxiiro
reviewed
Aug 7, 2025
zxiiro
left a comment
Collaborator
There was a problem hiding this comment.
I think we should resolve the typos but otherwise looks good to me!
izaitsevfb
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After fixing the bug, the new statistics are:
The main bug is that when checking for commits before/after with the same job, it actually concatenated all commits+jobs before and after, instead of only returning the next one.
I added also the ergonomics for lambda invocation