Skip to content

[Add API] get_time_series - #7073

Merged
yangw-dev merged 19 commits into
mainfrom
investigateCompiler
Sep 3, 2025
Merged

[Add API] get_time_series#7073
yangw-dev merged 19 commits into
mainfrom
investigateCompiler

Conversation

@yangw-dev

@yangw-dev yangw-dev commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Add api to get benchmark data as timeseries
currently it only support request with name: compiler_precompute,
will add general cases once we set up for torchao

this will be used as end point of benchmark regression report

@yangw-dev
yangw-dev requested a review from huydhn September 1, 2025 01:14
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 1, 2025
@vercel

vercel Bot commented Sep 1, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
torchci Ready Ready Preview Sep 3, 2025 8:03pm

Comment thread torchci/lib/benchmark/compilerUtils.ts
Comment thread torchci/lib/benchmark/api_helper/compilers/precompute.ts
@huydhn

huydhn commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Is there a curl command that I could use to get the data from the preview API? It would make the review easier to see what the time series data looks like

Comment thread torchci/lib/benchmark/compilerUtils.ts Outdated
return path.split(".").reduce((o, key) => (o && key in o ? o[key] : ""), obj);
}

export type BenchmarkTimeSeriesResponse = {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A curious question, do you know what is the relative size of BenchmarkTimeSeriesResponse when comparing with the raw result from ClickHouse? I want to confirm that BenchmarkTimeSeriesResponse is smaller

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's much smaller, i think we should probably precompute those if we can.
but that is next step

@yangw-dev yangw-dev Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a week's data

Tried it from postman app

url:
http://localhost:3000/api/benchmark/get_time_series

{
 "name":"compiler_precompute",
 "query_params":{
  "commits": [],
  "compilers": [],
  "arch": "h100",
  "device": "cuda",
  "dtype": "bfloat16",
  "granularity": "hour",
  "mode": "inference",
  "startTime":"2025-08-26T00:00:00",
  "stopTime": "2025-09-03T23:00:00",
  "suites": ["torchbench", "huggingface", "timm_models"],
  "workflowId": 0,
  "branches": ["main"]
 }
}

time to query

can up to 40 seconds now

size compare

  • BenchmarkTimeSeriesResponse: 13.29 KB
image
  • raw data response is more than 1.17 MB
image

Comment thread .gitignore Outdated
@yangw-dev
yangw-dev requested a review from huydhn September 3, 2025 17:47
Comment thread torchci/components/benchmark/compilers/SummaryGraphPanel.tsx Outdated
@yangw-dev
yangw-dev merged commit b55fed9 into main Sep 3, 2025
5 checks passed
@yangw-dev
yangw-dev deleted the investigateCompiler branch September 3, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants