Skip to content

[Helion Benchmark] Default to single view #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oulgen merged 1 commit into from
Sep 8, 2025
Merged

[Helion Benchmark] Default to single view #7123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions torchci/components/benchmark/llms/LLMsBenchmarkPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ const MainPage = ({
const options = data;
const dropdownMapList = getBenchmarkDropdownFeatures(options, props.repoName);
const metricNames = getMetricNames(data);
// Default to latest for Helion Benchmark, otherwise default to oldest commit
const lcommitFallbackIdx =
props.benchmarkName === "Helion Benchmark" ? 0 : -1;
return (
<div>
<Stack direction="row" spacing={2} sx={{ mb: 2 }}>
Expand All @@ -203,6 +206,7 @@ const MainPage = ({
props={props}
dispatch={dispatch}
queryParams={queryParams}
lcommitFallbackIdx={lcommitFallbackIdx}
/>
<LLMsReport
props={props}
Expand Down
5 changes: 4 additions & 1 deletion torchci/components/benchmark/llms/components/dashboardPicker/LLMsDashboardPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ export const LLMsDashboardPicker = ({
props,
dispatch,
queryParams,
lcommitFallbackIdx,
}: {
props: LLMsBenchmarkProps;
options?: DropdownGroupItem[];
dispatch: Dispatch<any>;
queryParams: any;
lcommitFallbackIdx: number;
}) => {
if (!options) {
return (
Expand All @@ -29,6 +31,7 @@ export const LLMsDashboardPicker = ({
const handleChange = (key: string, newVal: any) => {
dispatch({ type: "UPDATE_FIELD", field: key, value: newVal });
};

return (
<div>
<Stack direction="row" spacing={2} sx={{ mb: 2 }}>
Expand All @@ -50,7 +53,7 @@ export const LLMsDashboardPicker = ({
dispatch({ type: "UPDATE_FIELD", field: "lCommit", value: val });
}}
titlePrefix={"Base"}
fallbackIndex={-1} // Default to oldest commit
fallbackIndex={lcommitFallbackIdx}
timeRange={props.timeRange}
/>
<Divider orientation="vertical" flexItem>
Expand Down