Add binary r2 upload step to linux job - #7440
Merged
Merged
Conversation
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
jordanconway
approved these changes
Nov 6, 2025
jordanconway
left a comment
jordanconway
left a comment
Contributor
There was a problem hiding this comment.
Approving, but with a question about awscli version if it should be addressed.
| # shellcheck disable=SC1090 | ||
| source "${BUILD_ENV_FILE}" | ||
|
|
||
| pip install awscli==1.32.18 |
Contributor
There was a problem hiding this comment.
Is there a reason to use this specific, nearly 2 year old (Released: Jan 12, 2024) release of awscli?
Contributor
Author
There was a problem hiding this comment.
I agree let me unpin this
Contributor
There was a problem hiding this comment.
It may still be security best practices to pin in (in case of malicious takeover) but something more recent is probably better. 1.42.67 is the most recent release.
zxiiro
approved these changes
Nov 6, 2025
jordanconway
approved these changes
Nov 6, 2025
test fix fix fix upload_r2 fix fix test test
atalman
force-pushed
the
dual_r2_upload
branch
from
November 7, 2025 15:04
8c8f83a to
dfe981d
Compare
This was referenced Nov 7, 2025
atalman
added a commit
to atalman/test-infra
that referenced
this pull request
Dec 8, 2025
This reverts commit 8764320.
atalman
added a commit
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Cloudflare R2 upload