Skip to content

Fix Python 3.15 smoke tests on Windows and Linux #8357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atalman merged 1 commit into from
Aug 5, 2026
Merged

Fix Python 3.15 smoke tests on Windows and Linux #8357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .github/workflows/build_wheels_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,7 @@ jobs:
repository: ${{ inputs.repository }}
script: ${{ inputs.post-script }}
- name: Smoke Test
# Skip the smoke test for Python 3.15 / 3.15t: the wheel builds fine, but
# the smoke test installs the wheel which pulls required runtime deps
# (e.g. pillow, a hard torchvision dependency) that have no cp315 wheels
# yet and fail to build from sdist. Re-enable once the ecosystem ships
# cp315 wheels.
if: ${{ inputs.run-smoke-test && ! startsWith(matrix.python_version, '3.15') }}

@albanD albanD Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this for the linux wheel?

@atalman atalman Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @albanD yes, let me change description of the PR. I believe temporary change was committed here #8148 - which skipped smoke testing for 3.15 . We actually want to do some testing for 3.15 hence included it here

if: ${{ inputs.run-smoke-test }}
shell: bash -l {0}
env:
PACKAGE_NAME: ${{ inputs.package-name }}
Expand All @@ -317,7 +312,15 @@ jobs:
WHEEL_NAME=$(ls "${{ inputs.repository }}/dist/")
echo "$WHEEL_NAME"

${CONDA_RUN} pip install "${{ inputs.repository }}/dist/$WHEEL_NAME"
# numpy does not publish cp315 wheels on PyPI yet; they are available on
# download.pytorch.org as a pre-release. For 3.15 / 3.15t resolve runtime
# deps from there and allow pre-releases. Other versions use PyPI as before.
if [[ "${{ startsWith(matrix.python_version, '3.15') }}" == "true" ]]; then
${CONDA_RUN} pip install --pre "${{ inputs.repository }}/dist/$WHEEL_NAME" \
--index-url "https://download.pytorch.org/whl/${CHANNEL}/${CU_VERSION}"
else
${CONDA_RUN} pip install "${{ inputs.repository }}/dist/$WHEEL_NAME"
fi
# Checking that we have a pinned version of torch in our dependency tree
(
pushd "${RUNNER_TEMP}"
Expand Down
19 changes: 17 additions & 2 deletions .github/workflows/build_wheels_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,15 @@ jobs:
source "${BUILD_ENV_FILE}"
WHEEL_NAME=$(ls "${{ inputs.repository }}/dist/")
echo "$WHEEL_NAME"
${CONDA_RUN} pip install "${{ inputs.repository }}/dist/$WHEEL_NAME"
# numpy does not publish cp315 wheels on PyPI yet; they are available on
# download.pytorch.org as a pre-release. For 3.15 / 3.15t resolve runtime
# deps from there and allow pre-releases. Other versions use PyPI as before.
if [[ "${{ startsWith(matrix.python_version, '3.15') }}" == "true" ]]; then
${CONDA_RUN} pip install --pre "${{ inputs.repository }}/dist/$WHEEL_NAME" \
--index-url "https://download.pytorch.org/whl/${CHANNEL}/${CU_VERSION}"
else
${CONDA_RUN} pip install "${{ inputs.repository }}/dist/$WHEEL_NAME"
fi
if [[ ! -f "${{ inputs.repository }}"/${SMOKE_TEST_SCRIPT} ]]; then
echo "${{ inputs.repository }}/${SMOKE_TEST_SCRIPT} not found"
${CONDA_RUN} "${{ inputs.repository }}/${ENV_SCRIPT}" python -c "import ${PACKAGE_NAME}; print('package version is ', ${PACKAGE_NAME}.__version__)"
Expand All @@ -380,7 +388,14 @@ jobs:
cd $SRC_DIR
source .venv/Scripts/activate
whl=$(find dist -name "${{env.PACKAGE_NAME}}-*.whl" | head -n 1)
pip install $whl
# See the X64 smoke test above: for 3.15 / 3.15t numpy ships only on
# download.pytorch.org, as a pre-release.
if [[ "${{ startsWith(matrix.python_version, '3.15') }}" == "true" ]]; then
pip install --pre "$whl" \
--index-url "https://download.pytorch.org/whl/${CHANNEL}/${CU_VERSION}"
else
pip install "$whl"
fi

if [[ ! -f ${SMOKE_TEST_SCRIPT} ]]; then
echo "${SMOKE_TEST_SCRIPT} not found"
Expand Down
Loading