Run numpy preview upload in pytorchbot-env environment - #8369
Closed
atalman wants to merge 1 commit into
Closed
Conversation
The gha_workflow_nightly_build_wheels / gha_workflow_test_build_wheels OIDC roles and the R2 upload secrets are only assumable from the pytorchbot-env environment, so the upload run failed with 'Not authorized to perform sts:AssumeRoleWithWebIdentity'. Enter that environment for real upload runs (workflow_dispatch with dry_run disabled); dry runs and PR builds stay outside it so they are not gated on environment approval.
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Build numpy for preview Pythonworkflow (#8362) failed on a real (non-dry)workflow_dispatchupload run at the Configure AWS credentials step:The
gha_workflow_nightly_build_wheels/gha_workflow_test_build_wheelsOIDC roles (and theR2_*upload secrets) are only assumable from thepytorchbot-envenvironment — the same environment_binary_upload.ymlandupdate-s3-html.ymluse. The workflow didn't declare it, so the OIDC claim was rejected.Fix
Enter
pytorchbot-envfor real upload runs only:Dry runs and
pull_requestbuilds stay outside the environment so they aren't gated on environment approval (they don't touch AWS/R2 anyway).