Skip to content

Fix ROCm index URLs dropping the parent-directory hop #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atalman merged 1 commit into from
Aug 5, 2026
Merged

Fix ROCm index URLs dropping the parent-directory hop #8446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions s3_management/update_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import re
import time
from typing import Dict, List
from urllib.parse import urljoin

import boto3 # type: ignore[import-untyped]

Expand Down Expand Up @@ -836,13 +837,16 @@ def download(url: str) -> bytes:
return conn.read()


def replace_relative_links_with_absolute(html: str, base_url: str) -> str:
def replace_relative_links_with_absolute(
html: str, base_url: str, resolve_relative_paths: bool = False
) -> str:
"""
Replace all relative links in HTML with absolute links.

Args:
html: HTML content as string
base_url: Base URL to prepend to relative links
resolve_relative_paths: Resolve "../" segments against base_url (ROCm only)

Returns:
Modified HTML with absolute links
Expand All @@ -864,6 +868,10 @@ def replace_href(match):
):
return full_match

# ROCm wheels sit flat in whl-multi-arch/, so AMD hrefs are "../<wheel>.whl"
if resolve_relative_paths:
return f'href="{urljoin(base_url, url)}"'

# Remove leading ./ or /
url = url.lstrip("./")
url = url.lstrip("/")
Expand Down Expand Up @@ -902,7 +910,9 @@ def upload_index_html(
) -> None:
"""Upload modified index.html to S3 and R2 with absolute links"""
# Replace relative links with absolute links
modified_html = replace_relative_links_with_absolute(html, base_url)
modified_html = replace_relative_links_with_absolute(
html, base_url, resolve_relative_paths=is_amd_package(pkg_name)
)

index_key = f"{prefix}/{pkg_name}/index.html"

Expand Down
Loading