Allow-list the release lines' RC and GA tags for runner groups - #8502
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
Bot
added
the
CLA Signed
Release binaries are built from tags, not branches: pushing v2.14.0-rc1 runs the build workflows at refs/tags/v2.14.0-rc1. GitHub matches selected_workflows entries on the exact ref, so the @refs/heads/release/2.14 entries this script already emits do not authorize those runs, and the tag had to be added to the groups by hand for 2.14.0-rc1. Emit tag refs alongside the branch refs, for every pinned release line rather than just the candidate's, so a patch release on the preceding line keeps runner access too. Each line contributes its newest GA tag and its newest v<version>-rc<n>, ranked by (patch, rc) so v2.13.1-rc1 supersedes the rc15 that shipped as v2.13.0. Keeping only the newest of each is deliberate: pinning every tag would grow both the allow-list and the per-ref discovery cost by a workflow set per tag (2.13 reached rc15). A newer RC evicting an older one is fine - the allow-list is checked when a job starts, so in-flight builds are unaffected. Tags come from git/matching-refs, which returns the refs under the prefix in one request rather than paging pytorch/pytorch's entire tag history.
huydhn
changed the title
huydhn
force-pushed
the
release-runner-groups-rc-tags
branch
from
August 11, 2026 22:43
17febd7 to
f001d83
Compare
atalman
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release binaries are built from tags, not branches: pushing
v2.14.0-rc1runs the build workflows atrefs/tags/v2.14.0-rc1. GitHub matchesselected_workflowsentries on the exact ref, so the@refs/heads/release/2.14entries this script already emits don't authorize those runs — which is why https://github.com/pytorch/pytorch/actions/runs/31528881582 needed the tag added to the runner groups by hand.Emit tag refs alongside the branch refs, for every pinned release line, so a patch release on the preceding line keeps runner access too. Each line contributes its newest GA tag and its newest
v<version>-rc<n>, ranked by(patch, rc)sov2.13.1-rc1supersedes the rc15 that shipped asv2.13.0.Only the newest of each is kept — pinning every tag would grow the allow-list and the per-ref discovery cost by a workflow set per tag (2.13 reached rc15). Eviction is safe: the allow-list is checked when a job starts, so in-flight builds are unaffected.
Tags come from
git/matching-refs, one request instead of paging pytorch/pytorch's whole tag history.Testing
8 new unit tests, 22 pass.
lintrunnerclean. End-to-end against the live API in discovery-only mode:https://github.com/pytorch/test-infra/actions/runs/31543618002/job/93951275801#step:4:15