Skip to content

Normalize PACKAGE_LINKS_ALLOW_LIST to the spelling lookups actually use #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atalman merged 1 commit into from
Aug 12, 2026
Merged

Normalize PACKAGE_LINKS_ALLOW_LIST to the spelling lookups actually use #8513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions s3_management/manage_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,10 @@
# instead of processing wheels in subdirectories
# For example: whl/nightly/filelock/index.html -> whl/nightly/cu128/filelock/index.html
PACKAGE_LINKS_ALLOW_LIST = {
x.lower()
# Normalized to the underscore spelling every lookup uses: package names are
# derived from wheel filenames, and get_packages_to_copy_from_parent maps
# parent directory names through the same replace() before comparing.
x.lower().replace("-", "_")
for x in [
"filelock",
"sympy",
Expand All @@ -489,17 +492,11 @@
"fsspec",
"typing-extensions",
"spmd-types",
"spmd_types",
"cuda-bindings",
"cuda_bindings",
"cuda-toolkit",
# Underscore spelling is the one that matches; see "spmd_types" above.
"cuda-pathfinder",
"cuda_pathfinder",
"cuda-python",
"cuda_python",
"nvidia-ml-py",
"nvidia_ml_py",
"nvidia-cuda-nvrtc-cu12",
"nvidia-cuda-nvrtc",
"nvidia-cuda-runtime-cu12",
Expand Down
Loading