Skip to content

Exclude CUDA 13.4 from the docker release/validation matrix #8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeanschmidt wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

Exclude CUDA 13.4 from the docker release/validation matrix #8605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tools/scripts/generate_binary_build_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,14 @@
# and release builds and their validation are unchanged.
CUDA_ARCHES_NO_GETTING_STARTED = ["13.4"]

# CUDA versions with no official Docker image, mirroring the omissions from
# CUDA_ARCHES_FULL_VERSION in pytorch/pytorch, which drives the docker build
# matrix. Only affects the docker matrix; wheel and libtorch builds and their
# validation are unchanged. 13.4 is here because cuda-toolkit-13-4 ships only
# in NVIDIA's preview channel (packages.nvidia.com), not in the CUDA apt repo
# that pytorch/pytorch's release Dockerfile installs the devel toolkit from.
CUDA_ARCHES_NO_DOCKER = ["13.4"]

PACKAGE_TYPES = ["wheel", "libtorch"]
CXX11_ABI = "cxx11-abi"
RELEASE = "release"
Expand Down
7 changes: 6 additions & 1 deletion tools/scripts/generate_docker_release_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@ def generate_docker_matrix(
else:
docker_image_version = f"{prefix}-nightly:{generate_binary_build_matrix.CURRENT_NIGHTLY_VERSION}.dev{datetime.today().strftime('%Y%m%d')}"

for cuda in generate_binary_build_matrix.CUDA_ARCHES_DICT[channel]:
cuda_arches = [
cuda
for cuda in generate_binary_build_matrix.CUDA_ARCHES_DICT[channel]
if cuda not in generate_binary_build_matrix.CUDA_ARCHES_NO_DOCKER
]
for cuda in cuda_arches:
version = generate_binary_build_matrix.CUDA_CUDNN_VERSIONS[cuda]
for image in DOCKER_IMAGE_TYPES:
ret.append(
Expand Down
Loading