[CRCR] Add failed-tests-detail input to callback action and ingest path - #8607
Draft
subinz1 wants to merge 1 commit into
Draft
[CRCR] Add failed-tests-detail input to callback action and ingest path#8607subinz1 wants to merge 1 commit into
subinz1 wants to merge 1 commit into
Conversation
|
Deployment failed for project torchci with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
4 tasks
subinz1
marked this pull request as draft
August 24, 2026 12:12
Collaborator
Author
|
Addresses #8545 (ingest path portion). |
Add support for per-test failure details in the CRCR pipeline. The callback action now accepts a `failed-tests-detail` JSON array input containing test name, classname, message, and duration for each failed test. The ingest path (crcrUtils.ts) extracts and persists it as `failed_tests_json` in DynamoDB/ClickHouse. Size caps applied at both layers: max 50 entries, message truncated to 500 chars. This prevents unbounded growth in DynamoDB items while giving backend maintainers enough detail to identify which tests broke. Addresses #8545 (ingest path portion).
subinz1
force-pushed
the
crcr-failed-tests-ingest
branch
from
August 24, 2026 12:33
d498fc6 to
d779ae4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for per-test failure details in the CRCR pipeline, addressing the ingest portion of #8545.
failed-tests-detailinput accepting a JSON array of{name, classname, message, duration}objectsreport_callback.py: passes the new field asworkflow.failed_tests_detail, capped at 50 entriescrcrUtils.ts: extracts and persists asfailed_tests_jsonin DynamoDB/ClickHouse, with message truncation at 500 charsSize caps
Usage (downstream workflow)
Test plan
extractDynamoRecordpersistsfailed_tests_jsonwhen presentfailed-tests-detaildoesn't break existing flowCloses the ingest path portion of #8545. UI drill-down will follow in a separate PR.