This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Typo: Fix generate signature type hint for attention_backend#1471
Merged
Typo: Fix generate signature type hint for attention_backend#1471
Conversation
`attention_backend` is a SDPBackend, not a string
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1471
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 PendingAs of commit 7072dd6 with merge base b2d8f2a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Gasoonjia
approved these changes
Jan 22, 2025
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
`attention_backend` is a SDPBackend, not a string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attention_backendis a SDPBackend, not a stringFixing typo from #1456
cc: @yanbing-j