Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lighthouse quorum_ticks to use interval #100

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Feb 5, 2025

Small change to use tokio interval instead of sleep for quorum ticks:

before (some drift between tick times):

torchft::lighthouse: 2025-02-05T12:58:35.978-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T12:58:36.078-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T12:58:36.179-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T12:58:36.280-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T12:58:36.382-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T12:58:36.483-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T12:58:36.585-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]

after:

torchft::lighthouse: 2025-02-05T13:01:12.305-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T13:01:12.405-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T13:01:12.505-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T13:01:12.605-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T13:01:12.705-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]
torchft::lighthouse: 2025-02-05T13:01:12.805-08:00 - INFO Next quorum status: New quorum not, only have 0 participants, need min_replicas 2 [0/0 participants healthy][2 heartbeating][shrink_only=false]

@H-Huang H-Huang requested a review from d4l3k February 5, 2025 21:16
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 5, 2025
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k d4l3k merged commit 4d4d260 into pytorch:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants