Adds support for allgather_into_tensor_coalesced and reduce_scatter_tensor_coalesced
#114
+313
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes out #97
What does this PR do?
This PR introduces support for
allgather_into_tensor_coalescedandreduce_scatter_tensor_coalesced, similar to other supported collectives. This is a follow up to #108As noted in #108,
allgather_into_tensor_coalescedandreduce_scatter_tensor_coalescedare supported in the baseProcessGroupbut not withinProcessGroupNCCL.@d4l3k pointed out we may be able to create a regular
CppProcessGroupand register a backend, rather than return the backend which is what we were doing before, which seemed to work!