Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename torchft to _torchft in project.scripts section #115

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

mreso
Copy link
Contributor

@mreso mreso commented Feb 22, 2025

Seems like #84 renamed the module but it was not updated in the pyproject.toml.

Got ModuleNotFoundError: No module named 'torchft.torchft'

@mreso mreso requested a review from d4l3k February 22, 2025 00:05
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 22, 2025
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k
Copy link
Member

d4l3k commented Feb 22, 2025

We should probably add a test for this

@d4l3k d4l3k merged commit 5e65330 into pytorch:main Feb 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants