TimeoutManager: delete cuda events on main thread #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
fegin
reviewed
Mar 20, 2025
torchft/futures.py
Outdated
| while True: | ||
| try: | ||
| # get and immediately discard item | ||
| self._del_queue.get_nowait() |
There was a problem hiding this comment.
Do we want to do a sanity check to ensure there are no other reference to the event?
There was a problem hiding this comment.
Good suggestion! I added a getrefcount assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the TimeoutManager to use a deletion queue so we delete the CUDA events on the main thread. If we delete these on the background thread we can end up deadlocking and not calling future timeout.
This is critical for NCCL abort as cudaEventDestroy can block in scenarios when a NCCL operation is stuck.
Test plan:
Tested in torchtitan