Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifiy the devices when registering the backend to avoid warnings #16

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Specifiy the devices when registering the backend to avoid warnings #16

merged 1 commit into from
Nov 23, 2024

Conversation

fegin
Copy link
Contributor

@fegin fegin commented Nov 22, 2024 •
edited
Loading

If we don't specify the devices, c10d will print out the warning when we create a new group.

pytest process_group_test.py

@fegin fegin requested a review from d4l3k November 22, 2024 23:37
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 22, 2024
d4l3k
d4l3k approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k d4l3k merged commit c7a7f1e into main Nov 23, 2024
4 checks passed
@d4l3k d4l3k deleted the chienchin/pg_register_devices branch November 23, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fegin @d4l3k @facebook-github-bot