New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager: rename step to start_step + small shutdown fix #44

Merged

d4l3k merged 1 commit into main from d4l3k/manager_tweaks

Dec 18, 2024

Member

d4l3k commented Dec 16, 2024 •

edited

Loading

This is a small change to Manager to:

make it clearer by renaming step to start_step
shutdown the background thread to prevent leaks

Test plan:

pytest


          manager: rename step to start_step + small shutdown fix

8d0bbc3

facebook-github-bot added the CLA Signed label

Member Author

d4l3k commented Dec 18, 2024

CI passed locally, landing

d4l3k merged commit 78c5721 into main

4 of 6 checks passed

d4l3k deleted the d4l3k/manager_tweaks branch

December 18, 2024 00:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels