New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: compile -> compile_protos #53

Merged

d4l3k merged 1 commit into pytorch:main from Jackmin801:chore-dep-compile

Dec 20, 2024

Collaborator

Jackmin801 commented Dec 20, 2024

There's a warning about it. Goes away with this change

warning: use of deprecated method `tonic_build::Builder::compile`: renamed to `compile_protos()`
  --> build.rs:10:10
   |
10 |         .compile(&["proto/torchft.proto"], &["proto"])?;
   |          ^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: `torchft` (build script) generated 1 warning


          compile -> compile_protos

5f73266

facebook-github-bot added the CLA Signed label

d4l3k merged commit a32f807 into pytorch:main

6 checks passed

Member

d4l3k commented Dec 20, 2024

Yeah, I changed that because I hit some issue locally on my laptop but I think I have an old version cached for some reason

Jackmin801 deleted the chore-dep-compile branch

December 20, 2024 22:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels