Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose lighthouse join timeout #61

Merged
merged 5 commits into from
Jan 9, 2025
Merged

feat: expose lighthouse join timeout #61

merged 5 commits into from
Jan 9, 2025

Conversation

Jackmin801
Copy link
Collaborator

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 8, 2025
@Jackmin801 Jackmin801 force-pushed the feat-expose-lighthouse-join-timeout branch from 19a0b0f to 91624dd Compare January 8, 2025 09:29
c-p-i-o
c-p-i-o reviewed Jan 8, 2025
View reviewed changes
c-p-i-o
c-p-i-o approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@c-p-i-o c-p-i-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Minor comment above - but it's not blocking.

@Jackmin801 Jackmin801 force-pushed the feat-expose-lighthouse-join-timeout branch from b4caa97 to 653f192 Compare January 9, 2025 07:18
d4l3k
d4l3k approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k d4l3k merged commit 5dd6f38 into pytorch:main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

@c-p-i-o c-p-i-o c-p-i-o approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jackmin801 @d4l3k @c-p-i-o @facebook-github-bot