overhaul timeouts for Lighthouse, Manager, checkpoint server #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
d4l3k/timeout_overhaul
branch
from
e82057c to
663a292
Compare
Jackmin801
reviewed
Jan 16, 2025
| timeout. | ||
| timeout: the default timeout for all operations | ||
| Included: | ||
| * collectives such as allreduce |
There was a problem hiding this comment.
Doesnt seem like it currently applies to allreduce
There was a problem hiding this comment.
It does since the future from allreduce is wrapped via wrap_future which sets a timeout on the future
Jackmin801
reviewed
Jan 16, 2025
src/net.rs
Outdated
| max_backoff: Duration::from_secs(10), | ||
| timeout: connect_timeout, | ||
| factor: 1.5, | ||
| jitter: Duration::from_millis(100), |
There was a problem hiding this comment.
should jitter be random?
Jackmin801
approved these changes
Jan 16, 2025
c-p-i-o
reviewed
Jan 16, 2025
src/lib.rs
Outdated
| py.allow_threads(move || { | ||
| let runtime = Runtime::new()?; | ||
| let client = runtime | ||
| .block_on(manager::manager_client_new(addr, timeout)) | ||
| .block_on(manager::manager_client_new(addr, Duration::from_secs(60))) |
There was a problem hiding this comment.
you want to move these constants out or parameterize later?
There was a problem hiding this comment.
added a connect_timeout setting to Manager+ManagerClient, really should have done this a while back :)
c-p-i-o
reviewed
Jan 16, 2025
torchft/checkpointing.py
Outdated
|
|
||
| self.send_response(200) | ||
| self.send_header( | ||
| "Content-type", "tensor" |
There was a problem hiding this comment.
just wrapped this in a try catch but changed
c-p-i-o
approved these changes
Jan 16, 2025
d4l3k
force-pushed
the
d4l3k/timeout_overhaul
branch
from
663a292 to
4537a5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls the timeouts for all network operations to allow for long quorum timeouts in a safer way.
Notable changes:
quorum_timeoutfield to Manager py so you can have a much longer quorum timeoutTest plan: