Add docs to explain COMM_MODE #2162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
wwwjn
approved these changes
Dec 18, 2025
tianyu-l
approved these changes
Dec 19, 2025
Contributor
tianyu-l
left a comment
tianyu-l
left a comment
There was a problem hiding this comment.
debugging.md is becoming huge. We could either split it into multiple ones in a docs/debugging/ folder, or create a table of contents in the single file.
| - Simulates multi-GPU behavior on a single shared GPU | ||
| - Executes all collectives (all-reduce, all-gather, etc.) locally without network communication | ||
| - Maintains the same code paths as distributed training for accurate debugging | ||
| - Runs only one training step by default |
Contributor
There was a problem hiding this comment.
why having this as default?
| - Runs only one training step by default | ||
|
|
||
| **When to use it:** | ||
| - Debugging distributed training logic (FSDP, TP, PP, CP, EP) with data dependencies without multi-GPU setup |
Contributor
There was a problem hiding this comment.
add a note that fsdp doesn't work today?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As title