[checkpoint] Support fsspec checkpoint paths#3730
Conversation
|
|
fegin
left a comment
There was a problem hiding this comment.
I don't think it is a good idea to make fsspec as the default (we didn't do this for DCP either). Several reasons, we didn't measure the performance (probably not a big issue), unclear support of mmap, which can be a potential use case in the future.
I understand S3 support is important. A better design is to make fsspec as an option not default.
a649672 to
5b0f207
Compare
Done. DCP already tries fsspec in _storage_setup, so the only changes are the file management/discovery https://github.com/pytorch/pytorch/blob/main/torch/distributed/checkpoint/_storage_utils.py#L33 |
|
The title needs to be changed too. |
|
related PR #3887 |
make checkpointing fsspec aware, leave it to DCP to pick the appropriate writer/reader
when fsspec is used,
base_folderis not usedalso added unit test