Updated FSDP -> FSDPModule in doc
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Aug 20, 2024
ghstack-source-id: 28a28926bec3c1a6671a18b403deab0fc096d218 Pull Request resolved: #538
facebook-github-bot
added
the
CLA Signed
yifuwang
approved these changes
Aug 20, 2024
awgu
added a commit
that referenced
this pull request
Aug 20, 2024
ghstack-source-id: 28a28926bec3c1a6671a18b403deab0fc096d218 Pull Request resolved: #538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
FSDP->FSDPModulein doc #538We renamed the
FSDPclass toFSDPModulea while ago. We should update the doc.https://github.com/pytorch/pytorch/blob/33f1ee036ef79653023f1acbf43d2c9210072f2f/torch/distributed/_composable/fsdp/fully_shard.py#L159