Removed unused dw tensor in Triton RMSNorm #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Sep 2, 2024
ghstack-source-id: 146e0a951eb2329decf448d014a361cff2a800c5 Pull Request resolved: #567
facebook-github-bot
added
the
CLA Signed
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Sep 4, 2024
ghstack-source-id: c2337c6f976b41288498b7f3aa9b6f3d54d49ad9 Pull Request resolved: #567
awgu
commented
Sep 4, 2024
| @@ -284,7 +284,6 @@ def backward(ctx, dy): | |||
|
|
|||
| M, N = dy.shape | |||
| dx = torch.empty_like(x) | |||
| dw = torch.empty_like(weight) | |||
There was a problem hiding this comment.
unused, dw is directly computed:
torchtitan/torchtitan/models/norms.py
Line 315 in b7754d6
awgu
added a commit
that referenced
this pull request
Sep 4, 2024
ghstack-source-id: c2337c6f976b41288498b7f3aa9b6f3d54d49ad9 Pull Request resolved: #567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):