-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable Context Parallel #592
Draft
XilunWu
wants to merge
5
commits into
gh/XilunWu/6/base
Choose a base branch
from
gh/XilunWu/6/head
base: gh/XilunWu/6/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3bf7333
enable Context Parallel
XilunWu afb1051
Update on "enable Context Parallel"
XilunWu f99a6f5
Update on "enable Context Parallel"
XilunWu 4ad6881
Update on "enable Context Parallel"
XilunWu 038b5ce
Update on "enable Context Parallel"
XilunWu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,9 +8,11 @@ | |
# training techniques (e.g. activation checkpointing and compile) to the Llama model. | ||
|
||
from collections import defaultdict | ||
from typing import Tuple | ||
|
||
import torch | ||
import torch.nn as nn | ||
|
||
from torch.distributed import DeviceMesh | ||
from torch.distributed._composable.fsdp import fully_shard, MixedPrecisionPolicy | ||
from torch.distributed._composable.replicate import replicate | ||
|
@@ -72,13 +74,18 @@ def parallelize_llama( | |
) | ||
apply_compile(model) | ||
|
||
if parallel_dims.dp_enabled: | ||
if parallel_dims.dp_enabled or parallel_dims.cp_enabled: | ||
if parallel_dims.dp_shard_enabled: | ||
if parallel_dims.dp_replicate_enabled: | ||
dp_mesh = world_mesh["dp_replicate", "dp_shard"] | ||
else: | ||
dp_mesh = world_mesh["dp"] | ||
|
||
if parallel_dims.cp_enabled: | ||
dp_dim_names = dp_mesh.mesh_dim_names | ||
assert isinstance(dp_dim_names, Tuple) | ||
dp_mesh = world_mesh[(*dp_dim_names, "cp")]._flatten() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I remember we want to initialize all the PG in the very beginning. Can we move this to |
||
|
||
apply_fsdp( | ||
model, | ||
dp_mesh, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc., @tianyu-l Want to understand is this okay?
For a general use case, we can also expand the CP to support
stride
-like feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please elaborate a bit on why this change was needed by CP?