Make checkpoint purge thread to be a daemon thread #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2025
fegin
added a commit
that referenced
this pull request
Mar 17, 2025
Summary: This avoids potential deadlocks or freezes caused by exceptions on the main thread. Test Plan: Add an exception to the main thread. ghstack-source-id: 04cdf34c421169bc7c429a349e8b92edeea03bfa Pull Request resolved: #972
facebook-github-bot
added
the
CLA Signed
fduwjj
approved these changes
Mar 17, 2025
fegin
added a commit
that referenced
this pull request
Mar 17, 2025
Summary: This avoids potential deadlocks or freezes caused by exceptions on the main thread. Test Plan: Add an exception to the main thread. ghstack-source-id: 38309e3630b9fa21df9726046661df07f12e7117 Pull Request resolved: #972
fegin
added a commit
that referenced
this pull request
Mar 17, 2025
Reland #972 due to ghstack issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This avoids potential deadlocks or freezes caused by exceptions on the main thread.
Test Plan:
Add an exception to the main thread.