Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new released Falcon3 Family base models #2171

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from

Conversation

abdalgader-a
Copy link

Context

What is the purpose of this PR?

  • Add the set of new released (Dec 2024) Falcon3 base models.
  • Add full fine-tuning with single device and multi-devices.
  • Add LoRA fine-tuning with single device and multi-devices.

Copy link

pytorch-bot bot commented Dec 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2171

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @abdalgader-a!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@abdalgader-a abdalgader-a changed the title integrate falcon3 base models Integrate new released Falcon3 Family base models Dec 19, 2024
@joecummings
Copy link
Contributor

This looks pretty great and we'd love to have the new Falcon models!

Could you rebase this on torchtune:main instead of nightly?

@joecummings
Copy link
Contributor

Hey @abdalgader-a - are you still interested in working on this PR?

@abdalgader-a
Copy link
Author

abdalgader-a commented Jan 7, 2025

Hi @joecummings -- thanks for your interest on Falcon models! We are still working on the process of signing the CLA. Once done, I'll finalize this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants