-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored modules/tokenizers to be a subdir of modules/transforms #2231
base: main
Are you sure you want to change the base?
Refactored modules/tokenizers to be a subdir of modules/transforms #2231
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2231
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f6a5b2c with merge base 779569e (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2231 +/- ##
===========================================
+ Coverage 23.97% 64.11% +40.14%
===========================================
Files 358 353 -5
Lines 21207 20680 -527
===========================================
+ Hits 5084 13260 +8176
+ Misses 16123 7420 -8703 ☔ View full report in Codecov by Sentry. |
@joecummings looks like there is a merge conflict but I am unable to see it. How do I fix it? |
@Ankur-singh sorry we missed this comment until now. In my Github UI I see the following just above the "Add a comment" box (might be slightly different depending on your permissions). So seems like the merge conflict is in |
e6fff5f
to
779569e
Compare
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses. #1301
Changelog
What are the changes made in this PR?
modules/tokenizers
to be a subdir ofmodules/transforms
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example