-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the e2e flow tutorial to fix errors of generate #2251
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2251
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 6 PendingAs of commit 5d1280e with merge base c152248 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! just one small comment
docs/source/tutorials/e2e_flow.rst
Outdated
@@ -330,7 +332,7 @@ these parameters. | |||
|
|||
.. code-block:: text | |||
|
|||
$ tune run generate --config ./custom_generation_config.yaml prompt="tell me a joke. " | |||
$ tune run generate --config ./custom_generation_config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you try running this?
tune run generate --config ./custom_generation_config.yaml prompt.user="Tell me a joke. "
if that works fine, would prefer including this as an example just to be explicit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
==========================================
- Coverage 24.00% 23.95% -0.06%
==========================================
Files 357 358 +1
Lines 21094 21205 +111
==========================================
+ Hits 5064 5080 +16
- Misses 16030 16125 +95 ☔ View full report in Codecov by Sentry. |
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
When running the tutorial as is, there's error message:
checkpoint_dir
and make it different from theoutput_dir
.Then I saw the second error:
prompt
option from run. It's redundant with the prompt in the .yaml file anyway.Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example