Skip to content

Commit 10cc6f4

Browse files
kiukchungfacebook-github-bot
authored andcommitted
(torchx/local_scheduler) go back to using os.killpg in local_scheduler
Summary: Reverting the os.killpg -> os.kill part of #1062. Reviewed By: d4l3k Differential Revision: D74205288
1 parent 8216ac4 commit 10cc6f4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

torchx/schedulers/local_scheduler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def terminate(self) -> None:
311311
"""
312312
# safe to call terminate on a process that already died
313313
try:
314-
os.kill(self.proc.pid, signal.SIGTERM)
314+
os.killpg(self.proc.pid, signal.SIGTERM)
315315
except ProcessLookupError as e:
316316
log.debug(f"Process {self.proc.pid} already got terminated")
317317

0 commit comments

Comments
 (0)