Fix broken doc-push #1034
Merged
Fix broken doc-push #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72059926 |
kiukchung
added a commit
that referenced
this pull request
Mar 28, 2025
Summary: I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
kiukchung
force-pushed
the
export-D72059926
branch
from
1da12f4 to
b922cd7
Compare
Summary: Pull Request resolved: #1034 I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
|
This pull request was exported from Phabricator. Differential Revision: D72059926 |
kiukchung
force-pushed
the
export-D72059926
branch
from
b922cd7 to
fe086f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I fixed doc-build in #1033 by:
protobuf-3.20.xin torchx'sdev-requirements.txtsinceapache-airflow(defined indocs/requirements.txt) was upgrading toprotobuf>=5.xwhich is incompatible withkfp-1.8.x.doc/requirements.txtFIRST, then installingtorchxso that the pinned version ofprotobufis honored.The above fixes
doc-buildbut notdoc-pushbecausedoc-pushrunsscripts/doc-push.shwhich needed the same change as #2.Differential Revision: D72059926