Skip to content

feat: expose run_name via env in dist/spmd (#1035) #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

feat: expose run_name via env in dist/spmd (#1035) #1036

merged 1 commit into from
Mar 28, 2025

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Mar 28, 2025

See the title/linked feature request.

Test plan:
[x] updated unit tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@clumsy
Copy link
Contributor Author

clumsy commented Mar 28, 2025

@tonykao8080 @d4l3k @kiukchung for your consideration, thanks!

d4l3k
d4l3k approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k d4l3k merged commit f7ab10a into pytorch:main Mar 28, 2025
21 of 22 checks passed
@clumsy clumsy deleted the feat/dist_ddp_run_name branch March 28, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clumsy @d4l3k @facebook-github-bot @azzhipa