Skip to content

support AppStatus json output format #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

nghuiqin
Copy link
Contributor

Summary:
Enable json output format to show AppStatus

What added:

  1. Add --json subcommand for status, default is False
  2. Parse both AppStatus and RoleStatus to dictionary format
  3. json.dump dictionary in output
  4. Add unit test

Differential Revision: D73180040

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73180040

nghuiqin added a commit to nghuiqin/torchx that referenced this pull request Apr 17, 2025
Summary:

Enable json output format to show AppStatus

What added:
1. Add `--json` subcommand for `status`, default is False
2. Parse both AppStatus and RoleStatus to dictionary format
3. json.dump dictionary in output
4. Add unit test to check dict format.

Differential Revision: D73180040
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73180040

nghuiqin added a commit to nghuiqin/torchx that referenced this pull request Apr 17, 2025
Summary:

Enable json output format to show AppStatus

What added:
1. Add `--json` subcommand for `status`, default is False
2. Parse both AppStatus and RoleStatus to dictionary format
3. json.dump dictionary in output
4. Add unit test to check dict format.

Differential Revision: D73180040
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73180040

nghuiqin added a commit to nghuiqin/torchx that referenced this pull request Apr 18, 2025
Summary:

Enable json output format to show AppStatus

What added:
1. Add `--json` subcommand for `status`, default is False
2. Parse both AppStatus and RoleStatus to dictionary format
3. json.dump dictionary in output
4. Add unit test to check dict format.

Reviewed By: kiukchung

Differential Revision: D73180040
@nghuiqin nghuiqin force-pushed the export-D73180040 branch 2 times, most recently from 456ba47 to 31e5021 Compare April 18, 2025 11:00
nghuiqin added a commit to nghuiqin/torchx that referenced this pull request Apr 18, 2025
Summary:

Enable json output format to show AppStatus

What added:
1. Add `--json` subcommand for `status`, default is False
2. Parse both AppStatus and RoleStatus to json format
3. json.dump dictionary in output
4. Add unit test to check dict format.

Reviewed By: kiukchung

Differential Revision: D73180040
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73180040

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73180040

nghuiqin added a commit to nghuiqin/torchx that referenced this pull request Apr 18, 2025
Summary:
Pull Request resolved: pytorch#1045

Enable json output format to show AppStatus

What added:
1. Add `--json` subcommand for `status`, default is False
2. Parse both AppStatus and RoleStatus to json format
3. json.dump dictionary in output
4. Add unit test to check dict format.

Reviewed By: kiukchung

Differential Revision: D73180040
nghuiqin added a commit to nghuiqin/torchx that referenced this pull request Apr 19, 2025
Summary:

Enable json output format to show AppStatus

What added:
1. Add `--json` subcommand for `status`, default is False
2. Parse both AppStatus and RoleStatus to json format
3. json.dump dictionary in output
4. Add unit test to check dict format.

Reviewed By: kiukchung

Differential Revision: D73180040
Summary:
Pull Request resolved: pytorch#1045

Enable json output format to show AppStatus

What added:
1. Add `--json` subcommand for `status`, default is False
2. Parse both AppStatus and RoleStatus to json format
3. json.dump dictionary in output
4. Add unit test to check dict format.

Reviewed By: kiukchung

Differential Revision: D73180040
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73180040

@nghuiqin nghuiqin merged commit 6d6eebd into pytorch:main Apr 19, 2025
21 of 24 checks passed
@nghuiqin nghuiqin deleted the export-D73180040 branch April 19, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants