fix: ray module not found handling (#1049) #1055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TorchX has been handling
ModuleNotFoundError
gracefully for a while now, e.g. for SageMaker when runningtorchx runopts
we get:But for
ray
we get an exception after which we won't get next runopts:That's because
ray_scheduler
has customModuleNotFoundException
handling - perhaps for historic reasons.Test Plan: [x] existing test must pass
Differential Revision: D73751531
Pulled By: andywag