fix __file__ value inside components #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
daniel-ohayon
force-pushed
the
export-D73793210
branch
from
ce3bea9 to
c5a1bf9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73793210 |
daniel-ohayon
force-pushed
the
export-D73793210
branch
from
c5a1bf9 to
099d3e8
Compare
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Apr 30, 2025
Summary: Currently when we exec a component, we pass it the caller file's namespace. As a result, `__file__` resolves to `.../torchx/specs/finder.py` inside the compoennt at runtime, which is confusing. This fixes that. Reviewed By: crassirostris Differential Revision: D73793210
daniel-ohayon
force-pushed
the
export-D73793210
branch
from
099d3e8 to
1ecedf7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73793210 |
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Apr 30, 2025
Summary: Pull Request resolved: pytorch#1056 Currently when we exec a component, we pass it the caller file's namespace. As a result, `__file__` resolves to `.../torchx/specs/finder.py` inside the compoennt at runtime, which is confusing. This fixes that. Reviewed By: crassirostris Differential Revision: D73793210
daniel-ohayon
force-pushed
the
export-D73793210
branch
from
1ecedf7 to
5cb116c
Compare
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Apr 30, 2025
Summary: Currently when we exec a component, we pass it the caller file's namespace. As a result, `__file__` resolves to `.../torchx/specs/finder.py` inside the compoennt at runtime, which is confusing. This fixes that. Reviewed By: crassirostris Differential Revision: D73793210
daniel-ohayon
force-pushed
the
export-D73793210
branch
from
5cb116c to
3b8a7ed
Compare
Summary: Pull Request resolved: pytorch#1056 Currently when we exec a component, we pass it the caller file's namespace. As a result, `__file__` resolves to `.../torchx/specs/finder.py` inside the compoennt at runtime, which is confusing. This fixes that. Reviewed By: crassirostris Differential Revision: D73793210
|
This pull request was exported from Phabricator. Differential Revision: D73793210 |
daniel-ohayon
force-pushed
the
export-D73793210
branch
from
3b8a7ed to
250790a
Compare
kiukchung
approved these changes
Apr 30, 2025
| namespace = globals() | ||
| namespace = copy.copy(globals()) | ||
| # so that __file__ used inside the component points to the correct file | ||
| namespace["__file__"] = os.path.abspath(self._filepath) |
There was a problem hiding this comment.
would be great to add a unittest assertion for this (either as a testcase or simply adding an assertion in an existing testcase here: https://github.com/pytorch/torchx/blob/main/torchx/specs/test/finder_test.py#L194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently when we exec a component, we pass it the caller file's namespace. As a result,
__file__resolves to.../torchx/specs/finder.pyinside the compoennt at runtime, which is confusing.This fixes that.
Differential Revision: D73793210