Skip to content

fix nightly.yaml #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2024
Merged

fix nightly.yaml #867

merged 5 commits into from
Mar 30, 2024

Conversation

yikaiMeta
Copy link
Contributor

Test plan:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2024
@yikaiMeta
Copy link
Contributor Author

the default Linux github-hosted runner has 2 GPU, 7GB memory and 14 GB storage.
Here is github's official doc: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners
Haven't found the explanation of linux.20_04.4x but lots of our github Action yaml files are using it.

@yikaiMeta yikaiMeta marked this pull request as ready for review March 29, 2024 14:38
@yikaiMeta
Copy link
Contributor Author

Push nightly job runs all tests. Two tests fail.

@yikaiMeta yikaiMeta requested a review from d4l3k March 29, 2024 19:30
d4l3k
d4l3k approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good to me -- think the test failures are on main so that's expected

.github/workflows/nightly.yaml Outdated
@@ -22,7 +23,7 @@ jobs:
pip install -e .[dev]
pip install twine
- name: Run tests
run: python -m unittest discover --verbose --start-directory . --pattern "*_test.py"
run: pytest --verbose -o python_files="*_test.py"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter isn't necessary I don't think

Our main python tests just call pytest:

torchx/.github/workflows/python-unittests.yaml

Line 40 in 9f20e5a

run: pytest --cov=./ --cov-report=xml

.github/workflows/nightly.yaml Outdated
@@ -4,15 +4,16 @@ on:
# run every day at 11:15am
schedule:
- cron: '15 11 * * *'
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove before landing

@yikaiMeta yikaiMeta merged commit 45bc4ce into main Mar 30, 2024
20 checks passed
@yikaiMeta yikaiMeta deleted the yikaiMeta-patch-8 branch March 30, 2024 04:21
@ryxli
Copy link
Contributor

ryxli commented Apr 5, 2024

@yikaiMeta

Looks like nightly push runs still fail?
https://github.com/pytorch/torchx/actions/runs/8553750453/job/23437562048#step:5:13

Latest nightly release is from 2024.2.12

Believe pytest-cov needs to be added to dev-requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yikaiMeta @ryxli @d4l3k @facebook-github-bot