Fixed Multiple Args Testing Issue #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55525717 |
andywag
added a commit
to andywag/torchx
that referenced
this pull request
Mar 29, 2024
Summary: The purpose of the test was to check removal of multiple args. It passed internally using a facebook option but failed externally because the option didn't exist. Differential Revision: D55525717
andywag
force-pushed
the
export-D55525717
branch
from
ff76ace to
a371451
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55525717 |
Summary: The purpose of the test was to check removal of multiple args. It passed internally using a facebook option but failed externally because the option didn't exist. Differential Revision: D55525717
andywag
force-pushed
the
export-D55525717
branch
from
a371451 to
21bc480
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55525717 |
yikaiMeta
approved these changes
Mar 29, 2024
d4l3k
approved these changes
Mar 29, 2024
|
Regression was introduced in #854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The purpose of the test was to check removal of multiple args. It passed internally using a facebook option but failed externally because the option didn't exist.
Differential Revision: D55525717