remove log_dir from LaunchConfig #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55592319 |
yikaiMeta
force-pushed
the
export-D55592319
branch
from
76643ae to
5fb3ad4
Compare
yikaiMeta
added a commit
to yikaiMeta/torchx
that referenced
this pull request
Apr 1, 2024
Summary: D55562170 was trying to add a pyre-fixme. This diff removes the log_dir from arguments. Differential Revision: D55592319
|
This pull request was exported from Phabricator. Differential Revision: D55592319 |
Summary: D55562170 was trying to add a pyre-fixme. This diff removes the log_dir and tee from arguments. Differential Revision: D55592319
yikaiMeta
force-pushed
the
export-D55592319
branch
from
5fb3ad4 to
b050e51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55592319 |
andywag
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D55562170 was trying to add a pyre-fixme.
This diff removes the log_dir from arguments.
Differential Revision: D55592319