Install dependencies globally instead of using conda #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3144
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5be80c9 with merge base 6c0f792 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Nov 8, 2024
Comment on lines
5
to
9
| python3.10 -m venv /opt/venv/tutorials | ||
| source /opt/venv/tutorials/bin/activate | ||
| pip install --upgrade pip | ||
| pip install -r ./requirements.txt | ||
| chown ci-user:ci-user /opt/venv -R |
There was a problem hiding this comment.
Why do we need a venv here? It's our docker container, why not install dependencies system-wide?
clee2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using conda to install python and other dependnecies, and also don't use an conda environment. We don't even have any packages that are exclusively on conda.