Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] add docstring for prototype datasets #5843

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Apr 20, 2022

API
---

.. autofunction:: home
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just here to make the cross link from the dataset docstrings work.


.. autosummary::
:toctree: generated/
:template: class.rst
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not used the class_dataset.rst template here, since we no longer promote "special members", i.e. dunder methods like __getitem__.

@@ -54,7 +54,38 @@ class ImageNetDemux(enum.IntEnum):
@register_dataset(NAME)
class ImageNet(Dataset):
"""
$DESCRIPTION
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a placeholder, because I was to lazy to write something here for now. This should still be static and will not be filled at runtime.


.. warning::

The dataset files cannot be downloaded automatically!
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how we can put the download instructions here without duplicating them in the resources. I'm inclined to put something like "Just instantiate this and follow the instructions in the error message" here, but that also seems weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants