Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_prototype_datasets_builtin: Properly close all streams #7403

Merged
merged 2 commits into from
Mar 9, 2023
Merged

test_prototype_datasets_builtin: Properly close all streams #7403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
419d039
Properly close all streams
SvenDS9 Mar 9, 2023
65aee65
Merge branch 'main' into fix_test_prototytpe_datasets
pmeier Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/test_prototype_datasets_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def log_session_streams(self):
def test_stream_closing(self, log_session_streams, dataset_mock, config):
def make_msg_and_close(head):
unclosed_streams = []
for stream in StreamWrapper.session_streams.keys():
for stream in list(StreamWrapper.session_streams.keys()):
unclosed_streams.append(repr(stream.file_obj))
stream.close()
unclosed_streams = "\n".join(unclosed_streams)
Expand Down