-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Torchvision/fix issue 4295 #7985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7985
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit caee390 with merge base 35677ec ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Are there any known issues regarding the CI pipeline? I am not sure why the CI pipeline is failing on Lint. I did |
Hi @vilktor370 and thank for the PR. Quite a bit has changed since we opened #4295 and we have new "preferred" ways of performing these conversions. In particular, we have deprecated ToTensor and we have a new ToImage transform now, that can probably be preferred over PilToImage. With these new transforms, the overall story should be a bit simpler and probably doesn't require a full-fledge gallery example anymore. I think we can write a small paragraph here https://pytorch.org/vision/main/transforms.html#conversion instead, and explain that:
Does this make sense? |
A new example in the gallery is added as requested in this #4295. This new example is to show the difference between
to_tensor
,pil_to_tensor
, andto_pil_image
.cc @vfdev-5