Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install torchvision-extra-decoders from nightly channel #8963

Merged
merged 10 commits into from
Mar 17, 2025

Conversation

NicolasHug
Copy link
Member

No description provided.

Copy link

pytorch-bot bot commented Mar 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8963

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 7 Pending, 4 Unrelated Failures

As of commit 726eec8 with merge base de14de0 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug
Copy link
Member Author

We're going from:

2025-03-17T12:57:12.1247843Z �[31mFAILED�[0m test/test_image.py::�[1mtest_decode_bad_encoded_data[decode_heic-Invalid input: No 'ftyp' box]�[0m - OSError: /opt/conda/envs/ci/lib/python3.10/site-packages/torchvision_extra_decoders/extra_decoders_lib.so: undefined symbol: _ZN5torch3jit17parseSchemaOrNameERKSsb

To

2025-03-17T12:56:28.1186348Z �[31mFAILED�[0m test/test_image.py::�[1mtest_decode_avif[decode_avif]�[0m - OSError: /opt/conda/envs/ci/bin/../lib/libstdc++.so.6: version `GLIBCXX_3.4.31' not found (required by /opt/conda/envs/ci/lib/python3.10/site-packages/torchvision_extra_decoders/../torchvision_extra_decoders.libs/libheif-2b91cd5e.so.1)

So this is still progress. Before we had a torch symbol issue, now we have a glibcxx symbol issue. But it's mostly because the machines we're testing on are older than what torchvision-extra-decoder was built on. Sigh. I'll merge this and follow-up. As a first step I'll deactivate the tests but I'll also try to look into building torchvision-extra-decoder` with older dependencies (libheif, libavif) which hopefully won't require recent version symbols.

@NicolasHug NicolasHug merged commit a4d5121 into pytorch:main Mar 17, 2025
42 of 57 checks passed
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants