Skip to content

Port ps_roi_pool (CUDA) to stable ABI. - #9623

Merged
NicolasHug merged 2 commits into
mainfrom
adabeyta/ps-roi-pool-cuda-stable
Aug 25, 2026
Merged

Port ps_roi_pool (CUDA) to stable ABI. #9623
NicolasHug merged 2 commits into
mainfrom
adabeyta/ps-roi-pool-cuda-stable

Conversation

@adabeyta

@adabeyta adabeyta commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Notes

Stable-ABI audit (torch-abi-audit)

Ran torch-abi-audit. ps_roi_pool's CUDA op moves into the fully-STABLE _C_stable.so (unstable=0) and pulls in no new shim symbols. The unstable _C.so count is unchanged asince the kernel's unstable references are shared with the remaining unstable ops.

    Package: torchvision
      Torch ABI:   UNSTABLE
      CPython ABI: n/a
      Bundled libs: 3
      -- bundled libs --
        [UNSTABLE] [not-abi3] _C.so            (stable_shim=0,  unstable=85)
        [STABLE  ] [not-abi3] _C_stable.so     (stable_shim=74, unstable=0)
        [STABLE  ] [not-abi3] image_stable.so  (stable_shim=78, unstable=0)

@pytorch-bot

pytorch-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9623

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Pending, 1 Unclassified Failure

As of commit bad7096 with merge base ae0ca92 (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the cla signed label Aug 24, 2026
@adabeyta
adabeyta force-pushed the adabeyta/ps-roi-pool-cuda-stable branch from 3ff68d7 to 9de02c5 Compare August 24, 2026 17:15
@adabeyta
adabeyta force-pushed the adabeyta/ps-roi-pool-cuda-stable branch from 9de02c5 to 27f01e1 Compare August 24, 2026 18:24
@adabeyta adabeyta changed the title [Test] Port ps_roi_pool (CUDA) to stable ABI. Port ps_roi_pool (CUDA) to stable ABI. Aug 24, 2026
@adabeyta
adabeyta marked this pull request as ready for review August 24, 2026 21:15
@adabeyta
adabeyta requested a review from NicolasHug August 24, 2026 23:10

@NicolasHug NicolasHug left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@NicolasHug
NicolasHug merged commit 2f411e7 into main Aug 25, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants